NVSHAS-9078: fix online tlog verification failure #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinX-Suse
requested review from
jeffhuang4704,
williamlin-suse and
holyspectral
williamlin-suse
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SUSE Application Collection has signatures that do not include a "bundle". This means that offline verification of the TLOG (rekor) entry (which is our default behavior) is not possible, and so cosign must make a network request to a running rekor instance to verify transparency log claims.
Previously, in this case, no external Rekor URL was being provided, and this was causing this type of verification to break.
This PR also adds a
make testcommand that verifies real examples of "verification configs" that get sent to the sigstore-interface by the controller and scanner.